Adding CLI Configuration for DisableInformerCache Flag#2
Merged
Conversation
This is required for our helm charts where customers can opt to change the caching behaviour during restore.
mayankagg9722
requested review from
NarayanThiru,
anagg929,
bavneetsingh16 and
deeksha345
as code owners
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
bavneetsingh16
approved these changes
May 15, 2025
bavneetsingh16
pushed a commit
that referenced
this pull request
May 23, 2025
This is required for our helm charts where customers can opt to change the caching behaviour during restore.
bavneetsingh16
pushed a commit
that referenced
this pull request
May 23, 2025
This is required for our helm charts where customers can opt to change the caching behaviour during restore.
bavneetsingh16
pushed a commit
that referenced
this pull request
May 29, 2025
This is required for our helm charts where customers can opt to change the caching behaviour during restore.
bavneetsingh16
added a commit
that referenced
this pull request
May 30, 2025
* add pester tests for k8s-extension * Adding CLI Configuration for DisableInformerCache Flag (#2) This is required for our helm charts where customers can opt to change the caching behaviour during restore. * fix testcases for nodepool image issues (#5) * update readme and version release notes (#6) * fix: simplify logic and enable correct recording rule groups for managed prom extension (#7) * remove test cases specific to fork repo --------- Co-authored-by: Bavneet Singh <bavneetsingh@microsoft.com> Co-authored-by: Mayank Aggarwal <mayankagg9722@gmail.com> Co-authored-by: bragi92 <kadubey@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required for our helm charts where customers can opt to change the caching behaviour during restore.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
Create command:
az k8s-extension create --name azure-aks-backup --extension-type Microsoft.DataProtection.Kubernetes --scope cluster --cluster-name p1a-scaleTest-cluster --resource-group priyansh-p1a --cluster-type managedClusters --release-train stable --configuration-settings blobContainer=extension-aks storageAccountResourceGroup=priyansh-p1a storageAccount=p1ascalesa storageAccountSubscriptionId=a54fc8c4-a7cd-4ae1-b404-b2c317c2e58c disableInformerCache=true cpuRequest=1000m cpuLimit=1200m memoryRequest=300Mi memoryLimit=1800MiUpdate Command
az k8s-extension update --name azure-aks-backup --cluster-name p1a-scaleTest-cluster --resource-group priyansh-p1a --cluster-type managedClusters --release-train stable --configuration-settings blobContainer=extension-aks storageAccountResourceGroup=priyansh-p1a storageAccount=p1ascalesa storageAccountSubscriptionId=a54fc8c4-a7cd-4ae1-b404-b2c317c2e58c disableInformerCache=true cpuRequest=1000m cpuLimit=1200m memoryRequest=300Mi memoryLimit=1800MiGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.